diff options
| author | Vito Caputo <vcaputo@pengaru.com> | 2023-06-03 13:55:41 -0700 |
|---|---|---|
| committer | Vito Caputo <vcaputo@pengaru.com> | 2023-06-03 14:05:43 -0700 |
| commit | 126f38df518b4a26886b69a418d748af4f759dcd (patch) | |
| tree | b7bd750e8a1dcdac55187ebb9f3ee40ddc67b6b3 /src/til_settings.h | |
| parent | 8ceaa22c5e29edbc31bd9d7d8696b179fbf1f5b2 (diff) | |
til_settings: drop desc from til_settings_add_value()
In a world where "describing" settings is an iterative process,
especially post-nested-settings which are realized via the
desc-applying process, it's better to not even offer desc-setting
while adding a new setting.
This commit just gets rid of that.
The one caller that was passing a non-NULL desc to
til_settings_add_value(), til_module_setup_randomize(), was
redundantly doing so since the subsequent desc-processing was
assigning it again anyways. Future commits will likely change
til_module_setup_randomize() use a non-NULL desc for skipping
desc-applying, which wouldn't even work if it was always setting
the desc @ add time. That becomes necessary for partially
randomizing sparsely-populated settings.
Diffstat (limited to 'src/til_settings.h')
| -rw-r--r-- | src/til_settings.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/til_settings.h b/src/til_settings.h index e0b1875..e2653e4 100644 --- a/src/til_settings.h +++ b/src/til_settings.h @@ -49,7 +49,7 @@ til_settings_t * til_settings_free(til_settings_t *settings); unsigned til_settings_get_count(const til_settings_t *settings); const char * til_settings_get_value_by_key(const til_settings_t *settings, const char *key, til_setting_t **res_setting); const char * til_settings_get_value_by_idx(const til_settings_t *settings, unsigned idx, til_setting_t **res_setting); -til_setting_t * til_settings_add_value(til_settings_t *settings, const char *key, const char *value, const til_setting_desc_t *desc); +til_setting_t * til_settings_add_value(til_settings_t *settings, const char *key, const char *value); void til_settings_reset_descs(til_settings_t *settings); int til_settings_get_and_describe_value(const til_settings_t *settings, const til_setting_spec_t *spec, const char **res_value, til_setting_t **res_setting, const til_setting_desc_t **res_desc); char * til_settings_as_arg(const til_settings_t *settings); |