til_settings,setup: introduce til_setting_spec_t.override()

In situations where modules wish to alias setting values like
expanding "all" -> "mod0,mod1,mod2,mod3" they need a way to
intercept the value-acceptance @ desc-assignment time in the
front-end.  This optional override() function does just that when
present in the spec.

The current setting's value is passed to the override, and
if what's returned differs from what was passed (by pointer
value), then the current value is freed and the override takes
its place.  The override function is expected to _always_ return
non-NULL; either the value provided, or a newly allocated value
override.  The override function must never free the supplied
value, that's the front-end's job in applying the override.

The override() must return NULL on errors, which are assumed to
be limited to ENOMEM failures.

1 files changed, 17 insertions, 0 deletions

diff --git a/src/til.c b/src/til.c
index ee42e68..d006926 100644
--- a/src/til.c
+++ b/src/til.c
@@ -401,6 +401,23 @@ int til_module_setup_randomize(const til_module_t *module, unsigned seed, til_se
 
 			assert(setting);
 
+			/*
+			 * TODO This probably also needs to move into a til_settings helper,
+			 * copy-n-pasta alert, taken from setup.c
+			 */
+			if (desc->spec.override) {
+				const char	*o;
+
+				o = desc->spec.override(setting->value);
+				if (!o)
+					return -ENOMEM;
+
+				if (o != setting->value) {
+					free((void *)setting->value);
+					setting->value = o;
+				}
+			}
+
 			if (desc->spec.as_nested_settings && !setting->value_as_nested_settings) {
 				char	*label = NULL;