diff options
| author | Vito Caputo <vcaputo@pengaru.com> | 2023-06-03 13:55:41 -0700 |
|---|---|---|
| committer | Vito Caputo <vcaputo@pengaru.com> | 2023-06-03 14:05:43 -0700 |
| commit | 126f38df518b4a26886b69a418d748af4f759dcd (patch) | |
| tree | b7bd750e8a1dcdac55187ebb9f3ee40ddc67b6b3 /src/til.c | |
| parent | 8ceaa22c5e29edbc31bd9d7d8696b179fbf1f5b2 (diff) | |
til_settings: drop desc from til_settings_add_value()
In a world where "describing" settings is an iterative process,
especially post-nested-settings which are realized via the
desc-applying process, it's better to not even offer desc-setting
while adding a new setting.
This commit just gets rid of that.
The one caller that was passing a non-NULL desc to
til_settings_add_value(), til_module_setup_randomize(), was
redundantly doing so since the subsequent desc-processing was
assigning it again anyways. Future commits will likely change
til_module_setup_randomize() use a non-NULL desc for skipping
desc-applying, which wouldn't even work if it was always setting
the desc @ add time. That becomes necessary for partially
randomizing sparsely-populated settings.
Diffstat (limited to 'src/til.c')
| -rw-r--r-- | src/til.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -395,7 +395,7 @@ int til_module_setup_randomize(const til_module_t *module, unsigned seed, til_se char *value; value = desc->spec.random(rand_r(&seed)); - setting = til_settings_add_value(desc->container, desc->spec.key, value, desc); + setting = til_settings_add_value(desc->container, desc->spec.key, value); free(value); } else if (desc->spec.values) { int n; @@ -404,9 +404,9 @@ int til_module_setup_randomize(const til_module_t *module, unsigned seed, til_se n = rand_r(&seed) % n; - setting = til_settings_add_value(desc->container, desc->spec.key, desc->spec.values[n], desc); + setting = til_settings_add_value(desc->container, desc->spec.key, desc->spec.values[n]); } else { - setting = til_settings_add_value(desc->container, desc->spec.key, desc->spec.preferred, desc); + setting = til_settings_add_value(desc->container, desc->spec.key, desc->spec.preferred); } } |