summaryrefslogtreecommitdiff
path: root/src/modules
diff options
context:
space:
mode:
authorVito Caputo <vcaputo@pengaru.com>2023-11-14 19:31:36 -0800
committerVito Caputo <vcaputo@pengaru.com>2023-11-14 19:31:36 -0800
commita44c71ba3dcd57765b112c039b48513646c9e244 (patch)
tree03febc52aeed244f4f9a2085e91f8c7c6d662155 /src/modules
parentb7f773ae87ab037b94582005729fc15a22340f97 (diff)
til_stream,rkt,main: add stream audio control
Until now everything interested in audio just used a plain getter on the stream to get at the context. But with how things work currently, audio is always left in a paused state until explicitly unpaused. This works fine with modules/rkt, which manages pause/unpause explicitly. When there's nothing like modules/rkt in charge though, the audio just sits stuck paused. Meaning if you do some simple thing like --module=playit, it won't ever get unpaused. With this commit, something like modules/rkt takes control of the stream's audio context, in a way that prevents anything else from taking control of the same context on the same stream. That enables having main try take control of the audio context after creating the module contexts, then in the rendering thread ensure the audio is unpaused if main is in control of the audio context and something's queueing audio frames. For now there's no mechanism for releasing control of the audio context. It doesn't seem appropriate to make this more elaborate than necessary. There's basically just two use cases WRT audio: 1. Something like rkt, which takes control once for the process and stays in control until process exit. 2. Something far simpler where nothing's taking control like rkt, and main just needs to get things unpaused when needed because something's generating audio frames.
Diffstat (limited to 'src/modules')
-rw-r--r--src/modules/rkt/rkt.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/modules/rkt/rkt.c b/src/modules/rkt/rkt.c
index 7460161..f5221f4 100644
--- a/src/modules/rkt/rkt.c
+++ b/src/modules/rkt/rkt.c
@@ -286,7 +286,10 @@ static til_module_context_t * rkt_create_context(const til_module_t *module, til
if (!ctxt->scene_track)
return til_module_context_free(&ctxt->til_module_context);
- ctxt->audio_context = til_stream_get_audio_context(stream);
+ ctxt->audio_context = til_stream_get_audio_context_control(stream);
+ if (!ctxt->audio_context)
+ return til_module_context_free(&ctxt->til_module_context);
+
/* set the stream hooks early so context creates can establish taps early */
til_stream_set_hooks(stream, &rkt_stream_hooks, ctxt);
© All Rights Reserved