*: pivot to til_module_context_t

- modules now allocate their contexts using
  til_module_context_new() instead of [cm]alloc().

- modules simply embed til_module_context_t at the start of their
  respective private context structs, if they do anything with
  contexts

- modules that do nothing with contexts (lack a create_context()
  method), will now *always* get a til_module_context_t supplied
  to their other methods regardless of their create_context()
  presence.  So even if you don't have a create_context(), your
  prepare_frame() and/or render_fragment() methods can still
  access seed and n_cpus from within the til_module_context_t
  passed in as context, *always*.

- modules that *do* have a create_context() method, implying they
  have their own private context type, will have to cast the
  til_module_context_t supplied to the other methods to their
  private context type.  By embedding the til_module_context_t at
  the *start* of their private context struct, a simple cast is
  all that's needed.  If it's placed somewhere else, more
  annoying container_of() style macros are needed - this is
  strongly discouraged, just put it at the start of struct.

- til_module_create_context() now takes n_cpus, which may be set
  to 0 for automatically assigning the number of threads in its
  place.  Any non-zero value is treated as an explicit n_cpus,
  primarily intended for setting it to 1 for single-threaded
  contexts necessary when embedded within an already-threaded
  composite module.

- modules like montage which open-coded a single-threaded render
  are now using the same til_module_render_fragment() as
  everything else, since til_module_create_context() is accepting
  n_cpus.

- til_module_create_context() now produces a real type, not void
  *, that is til_module_context_t *.  All the other module
  context functions now operate on this type, and since
  til_module_context_t.module tracks the module this context
  relates to, those functions no longer require both the module
  and context be passed in.  This is especially helpful for
  compositing modules which do a lot of module context creation
  and destruction; the module handle is now only needed to create
  the contexts.  Everything else operating on that context only
  needs the single context pointer, not module+context pairs,
  which was unnecessarily annoying.

- if your module's context can be destroyed with a simple free(),
  without any deeper knowledge or freeing of nested pointers, you
  can now simply omit destroy_context() altogether.  When
  destroy_context() is missing, til_module_context_free() will
  automatically use libc's free() on the pointer returned from
  your create_context() (or on the pointer that was automatically
  created if you omitted create_context() too, for the
  bare til_module_context_t that got created on your behalf
  anyways).

For the most part, these changes don't affect module creation.

In some ways this eases module creation by making it more
convenient access seed and n_cpus if you had no further
requirement for a context struct.

In other ways it's slightly annoying to have to do type-casts
when you're working with your own context type, since before it
was all void* and didn't require casts when assigning to your
typed context variables.

The elimination for requiring a destroy_context() method in
simple free() of private context scenarios removes some
boilerplate in simple cases.

I think it's a wash for module writers, or maybe a slight win for
the simple cases.

1 files changed, 12 insertions, 17 deletions

diff --git a/src/modules/snow/snow.c b/src/modules/snow/snow.c
index bf0aee0..767459e 100644
--- a/src/modules/snow/snow.c
+++ b/src/modules/snow/snow.c
@@ -4,52 +4,48 @@
 
 #include "til.h"
 #include "til_fb.h"
+#include "til_module_context.h"
 
 /* Copyright (C) 2019 - Vito Caputo <vcaputo@pengaru.com> */
 
 /* This implements white noise / snow just using rand() */
 
 typedef union snow_seed_t {
-	char		__padding[256];		/* prevent seeds sharing a cache-line */
-	unsigned	seed;
+	char			__padding[256];		/* prevent seeds sharing a cache-line */
+	unsigned		seed;
 } snow_seed_t;
 
 typedef struct snow_context_t {
-	unsigned	unused;
-	snow_seed_t	seeds[];
+	til_module_context_t	til_module_context;
+	unsigned		unused;
+	snow_seed_t		seeds[];
 } snow_context_t;
 
 
-static void * snow_create_context(unsigned seed, unsigned ticks, unsigned n_cpus, til_setup_t *setup)
+static til_module_context_t * snow_create_context(unsigned seed, unsigned ticks, unsigned n_cpus, til_setup_t *setup)
 {
 	snow_context_t	*ctxt;
 
-	ctxt = calloc(1, sizeof(snow_context_t) + n_cpus * sizeof(snow_seed_t));
+	ctxt = til_module_context_new(sizeof(snow_context_t) + n_cpus * sizeof(snow_seed_t), seed, n_cpus);
 	if (!ctxt)
 		return NULL;
 
 	for (unsigned i = 0; i < n_cpus; i++)
 		ctxt->seeds[i].seed = rand_r(&seed);
 
-	return ctxt;
+	return &ctxt->til_module_context;
 }
 
 
-static void snow_destroy_context(void *context)
-{
-	free(context);
-}
-
-
-static void snow_prepare_frame(void *context, unsigned ticks, unsigned n_cpus, til_fb_fragment_t *fragment, til_fragmenter_t *res_fragmenter)
+static void snow_prepare_frame(til_module_context_t *context, unsigned ticks, til_fb_fragment_t *fragment, til_fragmenter_t *res_fragmenter)
 {
 	*res_fragmenter = til_fragmenter_slice_per_cpu;
 }
 
 
-static void snow_render_fragment(void *context, unsigned ticks, unsigned cpu, til_fb_fragment_t *fragment)
+static void snow_render_fragment(til_module_context_t *context, unsigned ticks, unsigned cpu, til_fb_fragment_t *fragment)
 {
-	snow_context_t	*ctxt = context;
+	snow_context_t	*ctxt = (snow_context_t *)context;
 	unsigned	*seed = &ctxt->seeds[cpu].seed;
 
 	for (unsigned y = fragment->y; y < fragment->y + fragment->height; y++) {
@@ -68,7 +64,6 @@ static void snow_render_fragment(void *context, unsigned ticks, unsigned cpu, ti
 
 til_module_t	snow_module = {
 	.create_context = snow_create_context,
-	.destroy_context = snow_destroy_context,
 	.prepare_frame = snow_prepare_frame,
 	.render_fragment = snow_render_fragment,
 	.name = "snow",