diff options
| author | Vito Caputo <vcaputo@pengaru.com> | 2023-08-30 17:26:56 -0700 |
|---|---|---|
| committer | Vito Caputo <vcaputo@pengaru.com> | 2023-08-30 17:26:56 -0700 |
| commit | c91c9e5eeae06a7cbed94354d62c1281dc356407 (patch) | |
| tree | a589ab8716cba804ec7c60e5882a2eec7f0033b7 /src/modules/drizzle/drizzle.c | |
| parent | 20d097ab1fe8ef5b62f4169f4353cc0074c27e4b (diff) | |
modules/*: til_module_context_free() error paths
Several modules still had vestigial ad-hoc free() cleanups on
error paths in their create_context().
Largely mechanical change of replacing those with
til_module_context_free() which is more appropriate, since the
til_module_context_t holds a reference on the setup. A plain
free() will leak that reference.
But it's only on create_context() failures which are uncommon,
so this was in practice mostly harmless...
Diffstat (limited to 'src/modules/drizzle/drizzle.c')
| -rw-r--r-- | src/modules/drizzle/drizzle.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/modules/drizzle/drizzle.c b/src/modules/drizzle/drizzle.c index 54ca204..18ef731 100644 --- a/src/modules/drizzle/drizzle.c +++ b/src/modules/drizzle/drizzle.c @@ -110,10 +110,8 @@ static til_module_context_t * drizzle_create_context(const til_module_t *module, return NULL; ctxt->puddle = puddle_new(PUDDLE_SIZE, PUDDLE_SIZE); - if (!ctxt->puddle) { - free(ctxt); - return NULL; - } + if (!ctxt->puddle) + return til_module_context_free(&ctxt->til_module_context); ctxt->taps.viscosity = til_tap_init_float(ctxt, &ctxt->viscosity, 1, &ctxt->vars.viscosity, "viscosity"); ctxt->taps.rainfall = til_tap_init_float(ctxt, &ctxt->rainfall, 1, &ctxt->vars.rainfall, "rainfall"); |