summaryrefslogtreecommitdiff
path: root/src/composite.h
diff options
context:
space:
mode:
authorVito Caputo <vcaputo@pengaru.com>2024-09-16 23:07:30 -0700
committerVito Caputo <vcaputo@pengaru.com>2024-09-16 23:07:30 -0700
commit97281be7bb92ca1c1c5f089b1242cf6e673688ee (patch)
tree862b27dfb6315020437a5c72daf675976bacece6 /src/composite.h
parente2bb7e45db6a9820292b6b01ce0dcdfae65cca9b (diff)
libvmon: Revert "libvmon: assume short positive reads found EOF"
This reverts commit 9f564cf8df6ef5fcba37082ba8013d6175955125. Experimenting with smaller initial seq_file buffers in the kernel has exposed this actually breaks, which contradicts my expectations for proc files established back in the /proc/mdstat racy incremental parsing corrupting the output days. I'm seeing /proc/$pid/task/$pid/children spit out short reads when the seq_file size is smaller than the amount of output. Userspace's read() call can provide a large buffer, and if seq_file's is smaller than the children output, it'll split the children output instead of enlarging the seq_file buf to the read() buffers bounds.
Diffstat (limited to 'src/composite.h')
0 files changed, 0 insertions, 0 deletions
© All Rights Reserved