*: s/void */til_setup_t */

This brings something resembling an actual type to the private
objects returrned in *res_setup.  Internally libtil/rototiller
wants this to be a til_setup_t, and it's up to the private users
of what's returned in *res_setup to embed this appropriately and
either use container_of() or casting when simply embedded at the
start to go between til_setup_t and their private containing
struct.

Everywhere *res_setup was previously allocated using calloc() is
now using til_setup_new() with a free_func, which til_setup_new()
will initialize appropriately.  There's still some remaining work
to do with the supplied free_func in some modules, where free()
isn't quite appropriate.

Setup freeing isn't actually being performed yet, but this sets
the foundation for that to happen in a subsequent commit that
cleans up the setup leaks.

Many modules use a static default setup for when no setup has
been provided.  In those cases, the free_func would be NULL,
which til_setup_new() refuses to do.  When setup freeing actually
starts happening, it'll simply skip freeing when
til_setup_t.free_func is NULL.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/til.c b/src/til.c
index f47e8ac..d7281ee 100644
--- a/src/til.c
+++ b/src/til.c
@@ -157,7 +157,7 @@ void til_module_render(const til_module_t *module, void *context, unsigned ticks
 }
 
 
-int til_module_create_context(const til_module_t *module, unsigned ticks, void *setup, void **res_context)
+int til_module_create_context(const til_module_t *module, unsigned ticks, til_setup_t *setup, void **res_context)
 {
 	void	*context;
 
@@ -191,7 +191,7 @@ void * til_module_destroy_context(const til_module_t *module, void *context)
 
 
 /* select module if not yet selected, then setup the module. */
-int til_module_setup(til_settings_t *settings, til_setting_t **res_setting, const til_setting_desc_t **res_desc, void **res_setup)
+int til_module_setup(til_settings_t *settings, til_setting_t **res_setting, const til_setting_desc_t **res_desc, til_setup_t **res_setup)
 {
 	til_setting_t		*setting;
 	const til_module_t	*module;
@@ -239,7 +239,7 @@ int til_module_setup(til_settings_t *settings, til_setting_t **res_setting, cons
 /* originally taken from rtv, this randomizes a module's setup @res_setup, args @res_arg
  * returns 0 on no setup, 1 on setup successful with results stored @res_*, -errno on error.
  */
-int til_module_randomize_setup(const til_module_t *module, void **res_setup, char **res_arg)
+int til_module_randomize_setup(const til_module_t *module, til_setup_t **res_setup, char **res_arg)
 {
 	til_settings_t			*settings;
 	til_setting_t			*setting;