til_setup,*: note settings path in til_setup_t

This commit adds passing the settings instance to til_setup_new()
which is used for deriving a path for the setup via
til_settings_print_path() on the supplied settings.

That path gets an allocated copy left in the returned
til_setup_t at til_setup_t.path

This path will exist for the lifetime of the til_setup_t, to be
freed along with the rest of the baked setup instance when the
refcount reaches 0.

The incoming til_settings_t is only read @ til_setup_new() in
constructing the path, no reference is kept.  Basically the
til_settings_t* is just passed in for convenience reasons, since
constructing the path needs memory and may fail, this approach
lets the existing til_setup_new() call error handling also
capture the path allocation failures as-is turning
til_setup_new() into a bit more of a convenience helper.

Note that now all code may assume a til_setup_t has a set and
valid til_setup_t.path, which should be useful for context
creates when a setup is available.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/modules/voronoi/voronoi.c b/src/modules/voronoi/voronoi.c
index 23ea00a..45333b0 100644
--- a/src/modules/voronoi/voronoi.c
+++ b/src/modules/voronoi/voronoi.c
@@ -403,7 +403,7 @@ static int voronoi_setup(const til_settings_t *settings, til_setting_t **res_set
 	if (res_setup) {
 		voronoi_setup_t	*setup;
 
-		setup = til_setup_new(sizeof(*setup), NULL);
+		setup = til_setup_new(settings, sizeof(*setup), NULL);
 		if (!setup)
 			return -ENOMEM;