modules/*: remove use of static default setups

There was a time when it made sense for context creates needing
setups but not receiving them to still be functional with some
sane defaults.

But with recursive settings, we really shouldn't ever have
orphaned nested module uses unreachable by a proper setup.

So let's just get rid of this fallback, and exclusively rely on
the baked setups provided by the .setup() methods.  They still
have preferred defaults, and the proper setup production
machinery is what should be responsible for applying those
at runtime where they may also be overridden or otherwise
influenced.

1 files changed, 0 insertions, 10 deletions

diff --git a/src/modules/voronoi/voronoi.c b/src/modules/voronoi/voronoi.c
index 209310d..56cbe0c 100644
--- a/src/modules/voronoi/voronoi.c
+++ b/src/modules/voronoi/voronoi.c
@@ -56,13 +56,6 @@ typedef struct voronoi_context_t {
 #define VORONOI_DEFAULT_RANDOMIZE	0
 
 
-static voronoi_setup_t voronoi_default_setup = {
-	.n_cells = VORONOI_DEFAULT_N_CELLS,
-	.dirty = VORONOI_DEFAULT_DIRTY,
-	.randomize = VORONOI_DEFAULT_RANDOMIZE,
-};
-
-
 static void voronoi_randomize(voronoi_context_t *ctxt)
 {
 	float	inv_rand_max= 1.f / (float)RAND_MAX;
@@ -84,9 +77,6 @@ static til_module_context_t * voronoi_create_context(const til_module_t *module,
 {
 	voronoi_context_t	*ctxt;
 
-	if (!setup)
-		setup = &voronoi_default_setup.til_setup;
-
 	ctxt = til_module_context_new(module, sizeof(voronoi_context_t) + ((voronoi_setup_t *)setup)->n_cells * sizeof(voronoi_cell_t), stream, seed, ticks, n_cpus, path);
 	if (!ctxt)
 		return NULL;