diff options
author | Vito Caputo <vcaputo@pengaru.com> | 2020-01-25 17:26:54 -0800 |
---|---|---|
committer | Vito Caputo <vcaputo@pengaru.com> | 2020-01-25 17:38:27 -0800 |
commit | 6385931985fa6fa8dd7ed69c20785d6b8d9cf37a (patch) | |
tree | 8fd19a7f72e60202367b417827112f7a57c0f24e /src/modules/submit | |
parent | 792d0a60dd05035435574633c4a13a666fe6ce5d (diff) |
rototiller: introduce ticks and wire up to modules
Most modules find themselves wanting some kind of "t" value increasing
with time or frames rendered. It's common for them to create and
maintain this variable locally, incrementing it with every frame
rendered.
It may be interesting to introduce a global notion of ticks since
rototiller started, and have all modules derive their "t" value from
this instead of having their own private versions of it.
In future modules and general innovations it seems likely that playing
with time, like jumping it forwards and backwards to achieve some
visual effects, will be desirable. This isn't applicable to all
modules, but for many their entire visible state is derived from their
"t" value, making them entirely reversible.
This commit doesn't change any modules functionally, it only adds the
plumbing to pull a ticks value down to the modules from the core.
A ticks offset has also been introduced in preparation for supporting
dynamic shifting of the ticks value, though no API is added for doing
so yet.
It also seems likely an API will be needed for disabling the
time-based ticks advancement, with functions for explicitly setting
its value. If modules are created for incorporating external
sequencers and music coordination, they will almost certainly need to
manage the ticks value explicitly. When a sequencer jumps
forwards/backwards in the creative process, the module glue
responsible will need to keep ticks synchronized with the
sequencer/editor tool.
Before any of this can happen, we need ticks as a first-class core
thing shared by all modules.
Future commits will have to modify existing modules to use the ticks
appropriately, replacing their bespoke variants.
Diffstat (limited to 'src/modules/submit')
-rw-r--r-- | src/modules/submit/submit.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/modules/submit/submit.c b/src/modules/submit/submit.c index 7035a3a..7b4fd91 100644 --- a/src/modules/submit/submit.c +++ b/src/modules/submit/submit.c @@ -261,7 +261,7 @@ static void setup_grid(submit_context_t *ctxt) } -static void * submit_create_context(unsigned num_cpus) +static void * submit_create_context(unsigned ticks, unsigned num_cpus) { submit_context_t *ctxt; @@ -290,7 +290,7 @@ static int submit_fragmenter(void *context, const fb_fragment_t *fragment, unsig } -static void submit_prepare_frame(void *context, unsigned n_cpus, fb_fragment_t *fragment, rototiller_fragmenter_t *res_fragmenter) +static void submit_prepare_frame(void *context, unsigned ticks, unsigned n_cpus, fb_fragment_t *fragment, rototiller_fragmenter_t *res_fragmenter) { submit_context_t *ctxt = context; @@ -311,7 +311,7 @@ static void submit_prepare_frame(void *context, unsigned n_cpus, fb_fragment_t * } -static void submit_render_fragment(void *context, unsigned cpu, fb_fragment_t *fragment) +static void submit_render_fragment(void *context, unsigned ticks, unsigned cpu, fb_fragment_t *fragment) { submit_context_t *ctxt = context; |