diff options
| author | Vito Caputo <vcaputo@pengaru.com> | 2023-05-11 12:48:42 -0700 |
|---|---|---|
| committer | Vito Caputo <vcaputo@pengaru.com> | 2023-05-11 15:19:25 -0700 |
| commit | 2b9eca8724fe6c5e0f6a4438cd398b5978283131 (patch) | |
| tree | 6e78ff7b7269926ddda6eb944cc2c97237e11b97 /src/modules/stars | |
| parent | caa75150ab4982c5ca0e48e606dd4f81087e7a3d (diff) | |
modules/*: remove use of static default setups
There was a time when it made sense for context creates needing
setups but not receiving them to still be functional with some
sane defaults.
But with recursive settings, we really shouldn't ever have
orphaned nested module uses unreachable by a proper setup.
So let's just get rid of this fallback, and exclusively rely on
the baked setups provided by the .setup() methods. They still
have preferred defaults, and the proper setup production
machinery is what should be responsible for applying those
at runtime where they may also be overridden or otherwise
influenced.
Diffstat (limited to 'src/modules/stars')
| -rw-r--r-- | src/modules/stars/stars.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/src/modules/stars/stars.c b/src/modules/stars/stars.c index 8dc18b8..51bb1c9 100644 --- a/src/modules/stars/stars.c +++ b/src/modules/stars/stars.c @@ -60,10 +60,6 @@ typedef struct stars_setup_t { float rot_adj; } stars_setup_t; -static stars_setup_t stars_default_setup = { - .rot_adj = DEFAULT_ROT_ADJ, -}; - float get_random_unit_coord(unsigned *seed) { return (((float)rand_r(seed)/(float)RAND_MAX)*2.0)-1.0; @@ -76,9 +72,6 @@ static til_module_context_t * stars_create_context(const til_module_t *module, t float z; struct points* p_ptr = NULL; - if (!setup) - setup = &stars_default_setup.til_setup; - ctxt = til_module_context_new(module, sizeof(stars_context_t), stream, seed, ticks, n_cpus, path); if (!ctxt) return NULL; |