diff options
| author | Vito Caputo <vcaputo@pengaru.com> | 2023-05-11 12:48:42 -0700 |
|---|---|---|
| committer | Vito Caputo <vcaputo@pengaru.com> | 2023-05-11 15:19:25 -0700 |
| commit | 2b9eca8724fe6c5e0f6a4438cd398b5978283131 (patch) | |
| tree | 6e78ff7b7269926ddda6eb944cc2c97237e11b97 /src/modules/rtv | |
| parent | caa75150ab4982c5ca0e48e606dd4f81087e7a3d (diff) | |
modules/*: remove use of static default setups
There was a time when it made sense for context creates needing
setups but not receiving them to still be functional with some
sane defaults.
But with recursive settings, we really shouldn't ever have
orphaned nested module uses unreachable by a proper setup.
So let's just get rid of this fallback, and exclusively rely on
the baked setups provided by the .setup() methods. They still
have preferred defaults, and the proper setup production
machinery is what should be responsible for applying those
at runtime where they may also be overridden or otherwise
influenced.
Diffstat (limited to 'src/modules/rtv')
| -rw-r--r-- | src/modules/rtv/rtv.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/src/modules/rtv/rtv.c b/src/modules/rtv/rtv.c index 82720b6..b48fa6b 100644 --- a/src/modules/rtv/rtv.c +++ b/src/modules/rtv/rtv.c @@ -72,15 +72,6 @@ static void rtv_render_fragment(til_module_context_t *context, til_stream_t *str static void rtv_finish_frame(til_module_context_t *context, til_stream_t *stream, unsigned ticks, til_fb_fragment_t **fragment_ptr); static int rtv_setup(const til_settings_t *settings, til_setting_t **res_setting, const til_setting_desc_t **res_desc, til_setup_t **res_setup); -static rtv_setup_t rtv_default_setup = { - .duration = RTV_DURATION_SECS, - .context_duration = RTV_CONTEXT_DURATION_SECS, - .snow_duration = RTV_SNOW_DURATION_SECS, - .caption_duration = RTV_CAPTION_DURATION_SECS, - .snow_module = RTV_DEFAULT_SNOW_MODULE, - .channels = { NULL }, /* NULL == "all" */ -}; - static til_module_t rtv_none_module = {}; til_module_t rtv_module = { @@ -234,9 +225,6 @@ static til_module_context_t * rtv_create_context(const til_module_t *module, til const til_module_t **modules; size_t n_modules, n_channels = 0; - if (!setup) - setup = &rtv_default_setup.til_setup; - til_get_modules(&modules, &n_modules); /* how many modules are in the setup? */ |