diff options
author | Vito Caputo <vcaputo@pengaru.com> | 2023-05-27 14:28:05 -0700 |
---|---|---|
committer | Vito Caputo <vcaputo@pengaru.com> | 2023-05-27 14:34:06 -0700 |
commit | 1ca8c79f3f003314967e58b90eadbcee27f7e785 (patch) | |
tree | ab911f6d53b9d0d28894daac12ae46f6e6e8a059 /src/modules/compose | |
parent | d412e89e8b61162fcf762cd23df3fcf609857a66 (diff) |
modules/rtv: don't use n_cpus=0 for the context creates
This is harmless as long as rtv stays hermetic.
But if rtv gets used in a composite scenario in the future by
either removing the hermetic flag, or allowing forced overrides,
n_cpus=0 will cause the nested module contexts to become threaded
on SMP machines.
That's problematic if the outer module context is already a
threaded render. What's appropriate here is to just propagate
the n_cpus down so if an upper layer has already gone threaded,
it will be sending down n_cpus=1 to serialize the nested
instances.
In practice, as-is, this change basically changes nothing, but
prepares for a potential future where rtv participates in
threaded compositions.
Through a lens of "rtv just rejiggers scenes and there settings
on a timer from a settings-specified subset of modules and
settings" it's arguably useful as just another module. Sometimes
you want something to change itself up periodically in say a
compose layer.
So preparing for this possibility isn't really all that
far-fetched/hypothetical.
Diffstat (limited to 'src/modules/compose')
0 files changed, 0 insertions, 0 deletions