modules/*: remove use of static default setups

There was a time when it made sense for context creates needing
setups but not receiving them to still be functional with some
sane defaults.

But with recursive settings, we really shouldn't ever have
orphaned nested module uses unreachable by a proper setup.

So let's just get rid of this fallback, and exclusively rely on
the baked setups provided by the .setup() methods.  They still
have preferred defaults, and the proper setup production
machinery is what should be responsible for applying those
at runtime where they may also be overridden or otherwise
influenced.

1 files changed, 0 insertions, 12 deletions

diff --git a/src/modules/checkers/checkers.c b/src/modules/checkers/checkers.c
index a2a767d..19c1232 100644
--- a/src/modules/checkers/checkers.c
+++ b/src/modules/checkers/checkers.c
@@ -70,23 +70,11 @@ typedef struct checkers_context_t {
 } checkers_context_t;
 
 
-static checkers_setup_t checkers_default_setup = {
-	.size = CHECKERS_DEFAULT_SIZE,
-	.pattern = CHECKERS_DEFAULT_PATTERN,
-	.dynamics = CHECKERS_DEFAULT_DYNAMICS,
-	.rate = CHECKERS_DEFAULT_DYNAMICS_RATE,
-	.color = CHECKERS_DEFAULT_COLOR,
-};
-
-
 static til_module_context_t * checkers_create_context(const til_module_t *module, til_stream_t *stream, unsigned seed, unsigned ticks, unsigned n_cpus, char *path, til_setup_t *setup)
 {
 	size_t			size = sizeof(checkers_context_t);
 	checkers_context_t	*ctxt;
 
-	if (!setup)
-		setup = &checkers_default_setup.til_setup;
-
 	if (((checkers_setup_t *)setup)->fill_module)
 		size += sizeof(til_module_context_t *) * n_cpus;