diff options
author | Vito Caputo <vcaputo@pengaru.com> | 2022-07-21 22:03:41 -0700 |
---|---|---|
committer | Vito Caputo <vcaputo@pengaru.com> | 2022-07-21 22:03:41 -0700 |
commit | 75bdc9a1563056582866f5bb370abee4c1a27538 (patch) | |
tree | e4acd2a25463af65720fdf94bb5a0173975ebfc7 /README | |
parent | cbfe780b20ced576c2e3d41361a9036210ab5c9b (diff) |
modules/{compose,rtv}: s/prepare_frame/render_fragment/
These modules have been doing their work in prepare_frame(), but
aren't actually threaded modules and don't return a frame plan
from prepare_frame() nor do they provide a render_fragment() to
complement the prepare_frame().
The convention thus far has been that single-threaded modules
just provide a render_fragment and by not providing a
prepare_frame they will be executed serially.
These two modules break the contract in a sense by using
prepare_frame() without following up with render_fragment().
I'm not sure why it happened that way, maybe at one time
prepare_frame() had access to some things that render_fragment()
didn't.
In any case, just make these use render_fragment() like any other
simple non-threaded module would.
This was actually causing a crash when n_cpus=1 because
module_render_fragment() was assuming the prepare_frame() branch
would include a render_fragment(). It should probably be
asserting as such.
Diffstat (limited to 'README')
0 files changed, 0 insertions, 0 deletions