diff options
| author | Vito Caputo <vcaputo@pengaru.com> | 2022-03-30 12:47:32 -0700 |
|---|---|---|
| committer | Vito Caputo <vcaputo@pengaru.com> | 2022-03-30 12:47:32 -0700 |
| commit | f3290897544c4427dc208d1dd1e33836639be8ba (patch) | |
| tree | 13312ec0926dd78c773902b74e89dec826e455f4 | |
| parent | 69077169545427acb2e8a3f1a487e6c144ed6f20 (diff) | |
til_settings: remove vestigial return missed by 7ff8ef
Commit 7ff8ef included some fast and dirty fixups to
til_settings_apply_desc_generators(), but left an inappropriate
return path out of the iterator resulting in the caller accessing
a NULL res_desc.
The practical result of this was segfaulting in rototiller when
configuring anything utilizing desc generators, like drm_fb.
| -rw-r--r-- | src/til_settings.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/til_settings.c b/src/til_settings.c index a1466d9..5d890d4 100644 --- a/src/til_settings.c +++ b/src/til_settings.c @@ -261,8 +261,6 @@ int til_settings_apply_desc_generators(const til_settings_t *settings, const til til_setting_desc_free(desc); /* always need to cleanup the desc from g->func(), res_desc gets its own copy */ if (r) return r; - - return 1; } return 0; |