summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVito Caputo <vcaputo@pengaru.com>2023-05-17 14:13:13 -0700
committerVito Caputo <vcaputo@pengaru.com>2023-05-17 14:13:13 -0700
commit396196b67f451db837cb9415d8d94b8d6aae2e08 (patch)
treede6f7303d8d7f5ba19e305fe41fc20f72554e6b8
parentb07dcecc6ae6abdc9ff7fab0179475903740ce43 (diff)
modules/rtv: make hermetic
As-is it's not great for rtv to randomly wind up in compositions, see comment in commit for more context.
-rw-r--r--src/modules/rtv/rtv.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/modules/rtv/rtv.c b/src/modules/rtv/rtv.c
index 35d968a..b491bf8 100644
--- a/src/modules/rtv/rtv.c
+++ b/src/modules/rtv/rtv.c
@@ -83,6 +83,13 @@ til_module_t rtv_module = {
.name = "rtv",
.description = "Rototiller TV",
.setup = rtv_setup,
+ .flags = TIL_MODULE_HERMETIC /* XXX TODO: this isn't strictly necessary, but;
+ * - it often just bogs things down when rtv gets into a random composition, and serves as path to recursive compose (potentially infinite)
+ * - one could argue that rtv may bring value in compositions as something reconfiguring a layer in a greater composition, and for that reason maybe it shouldn't be hermetic
+ * - if it comes back as non-hermetic, its log_channels setting should probably be prevented from randomization,
+ * either by hooking a fixed random() function on it or adding a spec flag for disabling randomization.
+ * - there should also be a more robust general defense against infinite (or even just stupidly deep) recursion via setup randomization
+ */
};
© All Rights Reserved