From 59701ade1169da559dd90c1892e97bb93191e78e Mon Sep 17 00:00:00 2001 From: Vito Caputo Date: Thu, 9 Jun 2022 07:45:16 -0700 Subject: modules/montage: remove vestigial unused variable This initializer could perform an out-of-bounds read since it occurs before the n_modules bounds check. Since the variable isn't even being used anymore just get rid of this. Also found via ASAN. --- src/modules/montage/montage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/modules/montage/montage.c b/src/modules/montage/montage.c index 443fcaa..4702564 100644 --- a/src/modules/montage/montage.c +++ b/src/modules/montage/montage.c @@ -192,7 +192,6 @@ static void montage_prepare_frame(til_module_context_t *context, unsigned ticks, static void montage_render_fragment(til_module_context_t *context, unsigned ticks, unsigned cpu, til_fb_fragment_t *fragment) { montage_context_t *ctxt = (montage_context_t *)context; - const til_module_t *module = ctxt->modules[fragment->number]; if (fragment->number >= ctxt->n_modules) { til_fb_fragment_clear(fragment); -- cgit v1.2.1