From 87ce3470bab09aa2d917fecd7401b9dfe09905d2 Mon Sep 17 00:00:00 2001 From: Vito Caputo Date: Tue, 8 Mar 2022 20:00:41 -0800 Subject: iou: update stale iou_op_new() comment At one time the cqe pointer was placed in the op, but at some point the cqe became "seen" before calling op->cb() to make the cqe available while op->cb() executed. None of my existing code required more than the result code which is already copied into iou_op_t by this point, so the cqe wasn't needed. --- src/iou.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/iou.c') diff --git a/src/iou.c b/src/iou.c index cdfc317..3e12ecc 100644 --- a/src/iou.c +++ b/src/iou.c @@ -239,9 +239,9 @@ iou_t * iou_free(iou_t *iou) /* allocates an op, which wraps an io_uring sqe, result, and associated closure */ /* when an op completes, its result member is populated from the cqe, and its - * closure supplied when queued is called. If the closure must access the cqe, - * it should bind the op by the submission time, then it may access the - * op->cqe member. + * callback supplied when queued is called with its accompanying + * cb_data pointer. Callback access to the raw cqe isn't currently + * facilitated. */ iou_op_t * iou_op_new(iou_t *iou) { -- cgit v1.2.3