From 1d35c60429534897d6fcc6fb5f2c503914b36671 Mon Sep 17 00:00:00 2001 From: Vito Caputo Date: Sun, 13 Apr 2025 13:46:36 -0700 Subject: vcr: treat negative values as top-rooted Instead of assigning top-down vs. bottom-up semantics to the layers behind vcr, let's use negative values to indicate top-down. This may change again in the future, but presently there's no support for signed bar graphs within a given layer. --- src/vcr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/vcr.c') diff --git a/src/vcr.c b/src/vcr.c index 0c01d03..20f726a 100644 --- a/src/vcr.c +++ b/src/vcr.c @@ -1221,6 +1221,10 @@ void vcr_draw_bar(vcr_t *vcr, vcr_layer_t layer, int row, float t, int min_heigh if (height > (VCR_ROW_HEIGHT - 1)) height = (VCR_ROW_HEIGHT - 1); + /* negative values project down from the top, positive up from bottom */ + if (t > 0.f) + y += VCR_ROW_HEIGHT - height - 1; + switch (vcr->backend->type) { #ifdef USE_XLIB case VCR_BACKEND_TYPE_XLIB: { @@ -1233,7 +1237,6 @@ void vcr_draw_bar(vcr_t *vcr, vcr_layer_t layer, int row, float t, int min_heigh break; case VCR_LAYER_GRAPHB: dest = &vcr->xlib.graphb_picture; - y += VCR_ROW_HEIGHT - height - 1; break; default: assert(0); @@ -1253,9 +1256,6 @@ void vcr_draw_bar(vcr_t *vcr, vcr_layer_t layer, int row, float t, int min_heigh uint8_t mask = (0x1 << layer) << ((vcr->phase & 0x1) << 2); uint8_t *p; - if (layer == VCR_LAYER_GRAPHB) - y += VCR_ROW_HEIGHT - height - 1; - p = &vcr->mem.bits[y * vcr->mem.pitch + (vcr->phase >> 1)]; for (int i = 0; i < height; i++, p += vcr->mem.pitch) *p |= mask; -- cgit v1.2.3