diff options
author | Vito Caputo <vcaputo@gnugeneration.com> | 2016-12-18 06:04:34 -0800 |
---|---|---|
committer | Vito Caputo <vcaputo@gnugeneration.com> | 2016-12-18 06:15:00 -0800 |
commit | c0c491486e6dc6112ffaa2eefacd0a324219b475 (patch) | |
tree | 1ab008af0e019e024076b2696d1e0682d5bf67be /src/desktop.h | |
parent | f92c2b443b380ddd17e5d9c9ac9a55e49cde444f (diff) |
overlay: fix bug with extraordinarily long argvs
This was a known bug, there's a TODO sitting right there noting it.
The items array was sized very large so it never triggered and was
forgotten about.
Running `make tags` in the linux kernel source steps on it though,
because it constructs a massive argv.
This just adds a bounds check so no crash occurs in argv2xtext().
I don't see the point of allocating memory for this as the TODO's
suggested, since any such argv is unlikely to fit in the overlay
anyways.
Also shrunk the max from 1024 to 512, which is still quite large.
Diffstat (limited to 'src/desktop.h')
0 files changed, 0 insertions, 0 deletions