From f3290897544c4427dc208d1dd1e33836639be8ba Mon Sep 17 00:00:00 2001 From: Vito Caputo Date: Wed, 30 Mar 2022 12:47:32 -0700 Subject: til_settings: remove vestigial return missed by 7ff8ef Commit 7ff8ef included some fast and dirty fixups to til_settings_apply_desc_generators(), but left an inappropriate return path out of the iterator resulting in the caller accessing a NULL res_desc. The practical result of this was segfaulting in rototiller when configuring anything utilizing desc generators, like drm_fb. --- src/til_settings.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src') diff --git a/src/til_settings.c b/src/til_settings.c index a1466d9..5d890d4 100644 --- a/src/til_settings.c +++ b/src/til_settings.c @@ -261,8 +261,6 @@ int til_settings_apply_desc_generators(const til_settings_t *settings, const til til_setting_desc_free(desc); /* always need to cleanup the desc from g->func(), res_desc gets its own copy */ if (r) return r; - - return 1; } return 0; -- cgit v1.2.3