From 1e664661cf35d22641521a1c4c22db1d071323aa Mon Sep 17 00:00:00 2001 From: Vito Caputo Date: Fri, 21 Feb 2020 12:24:30 -0800 Subject: settings: fixup win32 strndup Using strlen on the input string isn't safe; it may be unterminated --- src/settings.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/settings.c b/src/settings.c index 02c8e8d..aa256c5 100644 --- a/src/settings.c +++ b/src/settings.c @@ -13,7 +13,11 @@ char * strndup(const char *s, size_t n) size_t len; char *buf; - len = MIN(strlen(s), n); + for (len = 0; len < n; len++) { + if (!s[len]) + break; + } + buf = calloc(len + 1, sizeof(char)); if (!buf) return NULL; -- cgit v1.2.1