From c91c9e5eeae06a7cbed94354d62c1281dc356407 Mon Sep 17 00:00:00 2001 From: Vito Caputo Date: Wed, 30 Aug 2023 17:26:56 -0700 Subject: modules/*: til_module_context_free() error paths Several modules still had vestigial ad-hoc free() cleanups on error paths in their create_context(). Largely mechanical change of replacing those with til_module_context_free() which is more appropriate, since the til_module_context_t holds a reference on the setup. A plain free() will leak that reference. But it's only on create_context() failures which are uncommon, so this was in practice mostly harmless... --- src/modules/swab/swab.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/modules/swab/swab.c') diff --git a/src/modules/swab/swab.c b/src/modules/swab/swab.c index 9b7043c..343eb04 100644 --- a/src/modules/swab/swab.c +++ b/src/modules/swab/swab.c @@ -75,10 +75,8 @@ static til_module_context_t * swab_create_context(const til_module_t *module, ti return NULL; ctxt->din = din_new(12, 12, 100, seed); - if (!ctxt->din) { - free(ctxt); - return NULL; - } + if (!ctxt->din) + return til_module_context_free(&ctxt->til_module_context); return &ctxt->til_module_context; } -- cgit v1.2.1