From 9f9f9eaa096e6be8c1613014868e919d6991b188 Mon Sep 17 00:00:00 2001 From: Vito Caputo Date: Sun, 24 Apr 2022 19:24:47 -0700 Subject: *: s/void */til_setup_t */ This brings something resembling an actual type to the private objects returrned in *res_setup. Internally libtil/rototiller wants this to be a til_setup_t, and it's up to the private users of what's returned in *res_setup to embed this appropriately and either use container_of() or casting when simply embedded at the start to go between til_setup_t and their private containing struct. Everywhere *res_setup was previously allocated using calloc() is now using til_setup_new() with a free_func, which til_setup_new() will initialize appropriately. There's still some remaining work to do with the supplied free_func in some modules, where free() isn't quite appropriate. Setup freeing isn't actually being performed yet, but this sets the foundation for that to happen in a subsequent commit that cleans up the setup leaks. Many modules use a static default setup for when no setup has been provided. In those cases, the free_func would be NULL, which til_setup_new() refuses to do. When setup freeing actually starts happening, it'll simply skip freeing when til_setup_t.free_func is NULL. --- src/modules/submit/submit.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'src/modules/submit/submit.c') diff --git a/src/modules/submit/submit.c b/src/modules/submit/submit.c index e1f6008..f8e2ff0 100644 --- a/src/modules/submit/submit.c +++ b/src/modules/submit/submit.c @@ -58,6 +58,7 @@ typedef struct submit_context_t { } submit_context_t; typedef struct submit_setup_t { + til_setup_t til_setup; unsigned bilerp:1; } submit_setup_t; @@ -264,12 +265,12 @@ static void setup_grid(submit_context_t *ctxt) } -static void * submit_create_context(unsigned ticks, unsigned num_cpus, void *setup) +static void * submit_create_context(unsigned ticks, unsigned num_cpus, til_setup_t *setup) { submit_context_t *ctxt; if (!setup) - setup = &submit_default_setup; + setup = &submit_default_setup.til_setup; ctxt = calloc(1, sizeof(submit_context_t)); if (!ctxt) @@ -329,7 +330,7 @@ static void submit_render_fragment(void *context, unsigned ticks, unsigned cpu, } -static int submit_setup(const til_settings_t *settings, til_setting_t **res_setting, const til_setting_desc_t **res_desc, void **res_setup) +static int submit_setup(const til_settings_t *settings, til_setting_t **res_setting, const til_setting_desc_t **res_desc, til_setup_t **res_setup) { const char *values[] = { "off", @@ -357,14 +358,14 @@ static int submit_setup(const til_settings_t *settings, til_setting_t **res_sett if (res_setup) { submit_setup_t *setup; - setup = calloc(1, sizeof(*setup)); + setup = til_setup_new(sizeof(*setup), (void(*)(til_setup_t *))free); if (!setup) return -ENOMEM; if (!strcasecmp(bilerp, "on")) setup->bilerp = 1; - *res_setup = setup; + *res_setup = &setup->til_setup; } return 0; -- cgit v1.2.1