From c91c9e5eeae06a7cbed94354d62c1281dc356407 Mon Sep 17 00:00:00 2001 From: Vito Caputo Date: Wed, 30 Aug 2023 17:26:56 -0700 Subject: modules/*: til_module_context_free() error paths Several modules still had vestigial ad-hoc free() cleanups on error paths in their create_context(). Largely mechanical change of replacing those with til_module_context_free() which is more appropriate, since the til_module_context_t holds a reference on the setup. A plain free() will leak that reference. But it's only on create_context() failures which are uncommon, so this was in practice mostly harmless... --- src/modules/stars/stars.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/modules/stars') diff --git a/src/modules/stars/stars.c b/src/modules/stars/stars.c index bff3d8f..ef35c4e 100644 --- a/src/modules/stars/stars.c +++ b/src/modules/stars/stars.c @@ -123,7 +123,8 @@ static til_module_context_t * stars_create_context(const til_module_t *module, t for(int i=0; iseed)%16; i++){ p_ptr = malloc(sizeof(struct points)); if (!p_ptr) - return NULL; + return til_module_context_free(&ctxt->til_module_context); + p_ptr->x = get_random_unit_coord(&ctxt->seed); p_ptr->y = get_random_unit_coord(&ctxt->seed); p_ptr->z = z; -- cgit v1.2.3