From 2b9eca8724fe6c5e0f6a4438cd398b5978283131 Mon Sep 17 00:00:00 2001 From: Vito Caputo Date: Thu, 11 May 2023 12:48:42 -0700 Subject: modules/*: remove use of static default setups There was a time when it made sense for context creates needing setups but not receiving them to still be functional with some sane defaults. But with recursive settings, we really shouldn't ever have orphaned nested module uses unreachable by a proper setup. So let's just get rid of this fallback, and exclusively rely on the baked setups provided by the .setup() methods. They still have preferred defaults, and the proper setup production machinery is what should be responsible for applying those at runtime where they may also be overridden or otherwise influenced. --- src/modules/rkt/rkt.c | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/modules/rkt') diff --git a/src/modules/rkt/rkt.c b/src/modules/rkt/rkt.c index 6947fbb..6e5d016 100644 --- a/src/modules/rkt/rkt.c +++ b/src/modules/rkt/rkt.c @@ -46,17 +46,12 @@ typedef struct rkt_setup_t { unsigned short port; } rkt_setup_t; -static rkt_setup_t rkt_default_setup = { .seq_module_name = "compose" }; - static til_module_context_t * rkt_create_context(const til_module_t *module, til_stream_t *stream, unsigned seed, unsigned ticks, unsigned n_cpus, char *path, til_setup_t *setup) { rkt_context_t *ctxt; const til_module_t *seq_module; - if (!setup) - setup = &rkt_default_setup.til_setup; - seq_module = til_lookup_module(((rkt_setup_t *)setup)->seq_module_name); if (!seq_module) return NULL; -- cgit v1.2.3