From 2b9eca8724fe6c5e0f6a4438cd398b5978283131 Mon Sep 17 00:00:00 2001
From: Vito Caputo <vcaputo@pengaru.com>
Date: Thu, 11 May 2023 12:48:42 -0700
Subject: modules/*: remove use of static default setups
There was a time when it made sense for context creates needing
setups but not receiving them to still be functional with some
sane defaults.
But with recursive settings, we really shouldn't ever have
orphaned nested module uses unreachable by a proper setup.
So let's just get rid of this fallback, and exclusively rely on
the baked setups provided by the .setup() methods. They still
have preferred defaults, and the proper setup production
machinery is what should be responsible for applying those
at runtime where they may also be overridden or otherwise
influenced.
---
src/modules/flui2d/flui2d.c | 11 -----------
1 file changed, 11 deletions(-)
(limited to 'src/modules/flui2d')
diff --git a/src/modules/flui2d/flui2d.c b/src/modules/flui2d/flui2d.c
index f8e25d3..af25549 100644
--- a/src/modules/flui2d/flui2d.c
+++ b/src/modules/flui2d/flui2d.c
@@ -215,14 +215,6 @@ typedef struct flui2d_context_t {
#define FLUI2D_DEFAULT_DECAY .0001
-static flui2d_setup_t flui2d_default_setup = {
- .viscosity = FLUI2D_DEFAULT_VISCOSITY,
- .diffusion = FLUI2D_DEFAULT_DIFFUSION,
- .decay = FLUI2D_DEFAULT_DECAY,
- .emitters = FLUI2D_DEFAULT_EMITTERS,
-};
-
-
/* gamma correction derived from libs/ray/ray_gamma.[ch] */
static uint8_t gamma_table[1024];
@@ -262,9 +254,6 @@ static til_module_context_t * flui2d_create_context(const til_module_t *module,
static int initialized;
flui2d_context_t *ctxt;
- if (!setup)
- setup = &flui2d_default_setup.til_setup;
-
ctxt = til_module_context_new(module, sizeof(flui2d_context_t), stream, seed, ticks, n_cpus, path);
if (!ctxt)
return NULL;
--
cgit v1.2.3