From 51f3b575ee50b3c1ecf04e86ab0c30a08b499d86 Mon Sep 17 00:00:00 2001 From: Vito Caputo Date: Tue, 23 May 2023 22:29:41 -0700 Subject: modules/rtv: log_channels s/{yes,no}/{on,off}/ Using on/off for boolean settings is the established convention in rototiller, rtv went rogue here. Just make it consistent Sometimes it feels like this should be more flexible and support 0/1 yes/no true/false on/off by just having "boolean" typed settings. But I think it may actually pay off long-term to be so opinionated here and making serialized settings heirarchies directly hashable/comparable without major normalization steps (nothing beyond say... case normalization). --- src/modules/rtv/rtv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/rtv/rtv.c b/src/modules/rtv/rtv.c index b491bf8..8648ea3 100644 --- a/src/modules/rtv/rtv.c +++ b/src/modules/rtv/rtv.c @@ -333,8 +333,8 @@ static int rtv_setup(const til_settings_t *settings, til_setting_t **res_setting const char *snow_module; const char *log_channels; const char *log_channels_values[] = { - "no", - "yes", + "off", + "on", NULL }; int r; -- cgit v1.2.3